Spoiler Tag V1.5

Description:
This Mod will allow users to hide parts of their message. Usually used on film and games threads for not giving away the storyline.

Screenshots:






Zip Package:
SpoilerTag_V1_5.mod
SpoilerTag_German_DU_Patch.mod
yabbfiles/ModImages/SpoilerTag/spoiler.gif
yabbfiles/ModImages/SpoilerTag/spoiler1.gif

Files to edit:
Admin/ModList.pl
Languages/English/InstantMessage.lng
Languages/English/Main.lng
Languages/English/Post.lng
Sources/InstantMessage.pl
Sources/MyCenter.pl
Sources/Post.pl
Sources/Printpage.pl
Sources/YaBBC.pl

ubbc.js
yabbc.js

default.css
yabb21.css

Installation:
Before installing, copy 'ubbc.js' and 'yabbc.js' from your yabbfiles directory, and 'default.css' and 'yabb21.css' from yabbfiles/Templates/Forum, into your cgi-bin/yabbdirectory/ - Be sure to re-upload them back to their correct directory after.

Modify YaBB files using BoardMod or manually.
Load modified files to your server.  

Mod History:
1.0 - Original version - 30th July 2008
1.1 - Added to Instant Messages - 31st July 2008
1.2 - Added to Live Preview, Print Page and also added description function - 12th August 2008
1.3 - Updated for YaBB 2.3 - 14th October 2008
1.4 - Updated for YaBB 2.3.1 Forum Software - 5th January 2009
1.5 - Updated for YaBB 2.4 - 15th April 2009

You're very welcome MeisterGigi!

Hi Fairchild,

open the mod-File with an text-editor-Program and
you see, what you have to do.

Greetings
Mick

Hi,
Thanks so much Mick, Derek...I almost there...I've got this error message what I tried to install the spoiler tag...here are the error messages:

Step 1 ... failed - ERR(2): Could not find file to edit (C:\Documents and
Settings\Mahacon\Desktop\bm256\Mods\YaBB_2.4\cgi-bin\yabb2\Languages\German_Du\I
nstantMessage.lng)

Step 2 ... failed - ERR(2): Could not find file to edit (C:\Documents and
Settings\Mahacon\Desktop\bm256\Mods\YaBB_2.4\cgi-bin\yabb2\Languages\German_Du\M
ain.lng)

Step 3 ... failed - ERR(2): Could not find file to edit (C:\Documents and
Settings\Mahacon\Desktop\bm256\Mods\YaBB_2.4\cgi-bin\yabb2\Languages\German_Du\P
ost.lng)

Where am I doing wrong?

Yess!! I did it thanks to you! Thank you so much for this wonderful spoiler. It's working like a charm! God bless you!!

Hi again,
I was just wondering...how come mine has no that 'long box shaped'?

Greeeaaatt! It's working! I can't thank you enough. God bless!

Thanks, used parts of your mod for my old YaBB - our spoiler mod was a little buggy, yours is very nice . Oh, Chrome doesn't seem to care about the CSS style, Firefox, IE and Opera work well.

Hm, we have a problem with the tag. Some spoilers can't be opened. It seems to be totally randomly. For example on one page all spoiler buttons work, on the next only the first one. Or the first three work and the others don't. Any idea?

[Edit]:
Problem seems to appear only with Firefox.

I can.

Here it doesn't work

On the next page they work

But you have to test with Firefox, don't forget

WTF... now the one in the first link works. As I said... purely random.

And now it doesn't work again.

Works for me too in Firefox 3.6.3. Does they clear the cache or hold STRG (CTRL) + F5 Button to refresh the site?

Okay, yeah... It's just happened to me once too.

I haven't got a simple fix right now I'm afraid, but I'll try to sort it out once I've finished something else I'm working on...

I'm afraid I didn't write the JS from scratch, no (that's one reason why I wanted to change it). I looked up the best way of doing a spoiler a couple of years ago, and this seemed the most common and reliable way - this method actually seems to be quite widely used.

I still have no idea why it is happening though and I can't get it to happen on my test board. I can only think that it's playing up with another division or a bit of javascript on your page.

Can you try this (without modifying it) - Just replace yours with this from the first to last division:

Code:

<div class="message"><div><b>$spoiler_txt{'01'}:</b><input type="button" class="button" value="$spoiler_txt{'02'}" onclick="if (this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display != '') { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = ''; this.value = '$spoiler_txt{'03'}'; } else { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = 'none'; this.value = '$spoiler_txt{'02'}'; }" /></div><div class="spoiler"><div style="display: none;">$1</div></div></div> 

I'm not really hopeful that it will work though, all I've really done is make it xhtml valid.

Sorry, I have no idea. This is the error in FireFox:

Quote:

So I'm thinking it has to do with the doctype declaration on your page (though I can't recreate it).

Tools => Error Console

Valtiel wrote on 12.05.10 at 19:22:13:

I'm stuck what to suggest then. I have tried changing the doctype myself, but as I say, I can't recreate it.

I'm not 100% sure that is the problem, but have got a feeling that it must be.

Sorry again that I've not been able to help...

I tested some more. It has something to do with the content of the spoiler.

For example a post with 4 spoilers. None of them works. If I remove one special spoiler, the other 3 work.

Please try the following on your board, if possible:

Code:

[spoiler]wirklich [url=http://www.youtube.com/watch?v=Yn4r_XJw-Eg&feature=related]ALLES[/url] verstecken kann.[/spoiler] 

It's just how one of my mods posted the spoiler. It doesn't work and it makes all other spoilers in the same post not work, too.

Hm, if I edit the post and click on "Preview", the spoiler works. After posting, it doesn't.

The line is like your original, I just hardcoded the button text and added a line break:

Code:

    $message =~ s~\[spoiler\](.+?)\[/spoiler\]~<div class="message"><div><input type="button" class="button" value="Spoiler zeigen" onclick="if (this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display != '') { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = ''; this.value = 'Spoiler schließen'; } else { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = 'none'; this.value = 'Spoiler öffnen'; }" /></div><br><div class="spoiler"><div style="display: none;">$1</div></div></div></div>~isg; 

The break tag isn't from somewhere

Valtiel wrote on 12.05.10 at 20:04:23:


Anyway, it doesn't change anything.

I think I will figure it out. It has something to do with the <div> tags, it seems, just testing around a little bit.

Hm, it's really difficult...

Here is what we have by now:

• The error only appears with Firefox
• When clicking "Preview", the spoiler works. After posting, it doesn't
• It could have something to do with the spoiler's content

I need a coffee now    

If I remove the url=... stuff, the spoiler works. But that doesn't really help me.

No, I have no YaBB 2 to test. But I don't think it has something to do with it as the JavaScript should work in every environment - it's not even made especially for YaBB .

installed no probs thank you  

Seems my underline tag is not working on any templates now ... so there may be a small problem I need to work through.

Thanks bud.  Thought I was going crazy for a while there.