Page Index Toggle Pages: 1 [2] 3 4 5 Send TopicPrint
Very Hot Topic (More than 25 Replies) Chat CE 4 YaBB 2.4 ver. 1.2 (Read 4774 times)
Carsten
God Member
*****
Offline


...to much YaMS

Posts: 3281
Location: Langå
Joined: Aug 2nd, 2002
Gender: Male
Re: Chat CE 4 YaBB 2.4 beta 0.6
Reply #15 - Sep 30th, 2009 at 5:07pm
Print Post  
beta 0.7 - added admin option to set max. characters in chat messages. Added admin option to show / hide Chat button on Message Index. Fixed bug when excluding a board with the same id as a category.

New zip package attached to first post.

If no bugs or brilliant ideas emerge this will be the final version  Wink
  

If you knock your head against a brick wall and hear a hollow sound, it's not necessarily coming from the wall.
Back to top
 
IP Logged
 
Derek Barnstorm
God Member
*****
Offline



Posts: 1146
Location: Warwickshire
Joined: Mar 23rd, 2008
Gender: Male
Re: Chat CE 4 YaBB 2.4 beta 0.6
Reply #16 - Sep 30th, 2009 at 6:15pm
Print Post  
Thanks Carsten!

I like the idea of the button in MessageIndex.

A couple of things before you make it final:

Another Safari thing I'm afraid. When using the subscript and superscript I can't get back out of it. Either way I do it, if I just click the button to use them, or highlight the text first and then click the button, all text after is in subscript or superscript and I can't cancel it. As I say, I think this is only happening in Safari, it's fine in FireFox, and all the other code buttons work fine - unless it's just me being silly. Huh

And if you don't mind me making a simple suggestion, I don't know if you think it's a good idea or not, but how about adding a pop-up alert when deleting a comment?

I did it the same way as it's done in the rest of YaBB by adding this to your language file:

Code
Select All
'remove_alert' => "Are you sure you want to remove this comment?", 


And then adding the highlighted to this line in ChatCE.pl:

Code
Select All
			$deletech .= qq~<a href="$scripturl?action=cdupdatechat;room=$thisroom;delete=$key" onclick="return confirm('$chatce_txt{'remove_alert'}');"><img src='$defaultimagesdir/im_delete.gif' alt="$chatce_txt{'remove'}" title="$chatce_txt{'remove'}" border="0" /></a>~; 

  
Back to top
 
IP Logged
 
Carsten
God Member
*****
Offline


...to much YaMS

Posts: 3281
Location: Langå
Joined: Aug 2nd, 2002
Gender: Male
Re: Chat CE 4 YaBB 2.4 beta 0.6
Reply #17 - Sep 30th, 2009 at 7:30pm
Print Post  
Thanks Derek - your testing is highly appreciated...

As far as i can tell the Super- / Subscript works as it's supposed to and the same way as in most (- FF) other browsers (and MS Word and OO Writer too  Wink )

Please remember that a wysiwyg editor works very similar to ordinary word processors - you write your text and then you format it - or you write some text and then you click a button (say the Superscript button) and write the text you want in that format and then click the same button again to return to unformatted text.

About the delete alert, i did consider that but found i liked it better the way it is. Chat consists of small 'volatile' messages that should be easy to delete for moderators. When deleting five in a row i found it annoying to have to confirm every single time - but i guess that's a matter of opinion.
  

If you knock your head against a brick wall and hear a hollow sound, it's not necessarily coming from the wall.
Back to top
 
IP Logged
 
Derek Barnstorm
God Member
*****
Offline



Posts: 1146
Location: Warwickshire
Joined: Mar 23rd, 2008
Gender: Male
Re: Chat CE 4 YaBB 2.4 beta 0.6
Reply #18 - Sep 30th, 2009 at 8:42pm
Print Post  
Ah, I hadn't got the updates for my Mac in a while, and I was testing in Safari 3.2.1. I was using the editor correctly but, for some reason the sup/sub wasn't working as it should in that version.

Anyhow, I've just tested it on Safari 4.0.3 on Mac and Windows and it's all working as it should. Sorry about the confusion, I should have made sure I was up to date before testing. It must have just been how it was handled in older versions of Safari. It all works great now anyway!

No worries about the pop-up alert, it was just a suggestion for clumsy people like myself. I see your point of it being easier to delete multiple messages.

One thing I have just this minute thought of though is, what if Admins or GMods are in stealth mode? Should they still be shown in chat participants online?
  
Back to top
 
IP Logged
 
Carsten
God Member
*****
Offline


...to much YaMS

Posts: 3281
Location: Langå
Joined: Aug 2nd, 2002
Gender: Male
Re: Chat CE 4 YaBB 2.4 beta 0.6
Reply #19 - Oct 1st, 2009 at 12:07am
Print Post  
Derek Barnstorm wrote on Sep 30th, 2009 at 8:42pm:
One thing I have just this minute thought of though is, what if Admins or GMods are in stealth mode? Should they still be shown in chat participants online?

Yep - makes sense. Fixed. New package attached to first post.
  

If you knock your head against a brick wall and hear a hollow sound, it's not necessarily coming from the wall.
Back to top
 
IP Logged
 
Derek Barnstorm
God Member
*****
Offline



Posts: 1146
Location: Warwickshire
Joined: Mar 23rd, 2008
Gender: Male
Re: Chat CE 4 YaBB 2.4 beta 0.6
Reply #20 - Oct 1st, 2009 at 12:52am
Print Post  
Works great. Thank you!

You really are going to hate me for this though, I've just spotted another thing in Safari (4.0.3 - Mac and Windows), the max characters left is wrong. See the attached image, it shows 'Remaining characters: 299' when it should be 'Remaining characters: 300'.

It works as it should in FireFox.
  

ChatMaxChar.png ( 15 KB | Downloads )
ChatMaxChar.png
Back to top
 
IP Logged
 
Carsten
God Member
*****
Offline


...to much YaMS

Posts: 3281
Location: Langå
Joined: Aug 2nd, 2002
Gender: Male
Re: Chat CE 4 YaBB 2.4 beta 0.6
Reply #21 - Oct 1st, 2009 at 1:06am
Print Post  
Derek Barnstorm wrote on Oct 1st, 2009 at 12:52am:
You really are going to hate me for this though

Nooo way!

Derek Barnstorm wrote on Oct 1st, 2009 at 12:52am:
I've just spotted another thing in Safari (4.0.3 - Mac and Windows), the max characters left is wrong. See the attached image, it shows 'Remaining characters: 299' when it should be 'Remaining characters: 300'.

Yep i know - same thing in Opera. I've been struggeling with that little bugger for a while now. If you start with backward delete it actually goes to 300  Huh
  

If you knock your head against a brick wall and hear a hollow sound, it's not necessarily coming from the wall.
Back to top
 
IP Logged
 
Carsten
God Member
*****
Offline


...to much YaMS

Posts: 3281
Location: Langå
Joined: Aug 2nd, 2002
Gender: Male
Re: Chat CE 4 YaBB 2.4 beta 0.7.2
Reply #22 - Oct 1st, 2009 at 1:34am
Print Post  
Derek Barnstorm wrote on Oct 1st, 2009 at 12:52am:
the max characters left is wrong. See the attached image, it shows 'Remaining characters: 299' when it should be 'Remaining characters: 300'.

Fixed - one silly newline character did it  Cheesy

Changes only in ChatCE.pl

New zip in first post.
  

If you knock your head against a brick wall and hear a hollow sound, it's not necessarily coming from the wall.
Back to top
 
IP Logged
 
Derek Barnstorm
God Member
*****
Offline



Posts: 1146
Location: Warwickshire
Joined: Mar 23rd, 2008
Gender: Male
Re: Chat CE 4 YaBB 2.4 beta 0.7.2
Reply #23 - Oct 1st, 2009 at 1:41am
Print Post  
Yep, perfect!

I haven't noticed anything else amiss, so I should be able to leave you in peace now. Wink

Thank you! Smiley
  
Back to top
 
IP Logged
 
Carsten
God Member
*****
Offline


...to much YaMS

Posts: 3281
Location: Langå
Joined: Aug 2nd, 2002
Gender: Male
Re: Chat CE 4 YaBB 2.4 beta 0.7.2
Reply #24 - Oct 2nd, 2009 at 10:02pm
Print Post  
beta 0.8 - added admin option to enable/disable alert before deleting chat comment (favor to Derek for loyal testing  Smiley ). Added "Clear" button to reset the editor.Made some code streamlining.

New zip at first post.
  

If you knock your head against a brick wall and hear a hollow sound, it's not necessarily coming from the wall.
Back to top
 
IP Logged
 
Derek Barnstorm
God Member
*****
Offline



Posts: 1146
Location: Warwickshire
Joined: Mar 23rd, 2008
Gender: Male
Re: Chat CE 4 YaBB 2.4 beta 0.7.2
Reply #25 - Oct 3rd, 2009 at 12:44am
Print Post  
Carsten wrote on Oct 2nd, 2009 at 10:02pm:
added admin option to enable/disable alert before deleting chat comment (favor to Derek for loyal testing  Smiley

That's great! Thanks! Cheesy

Something has been puzzling me with the deselecting of categories though. I noticed this the other day, but didn't want to say anything until I'd checked it on a fresh install.

Anyhow, If I select a category in Admin Center by selecting only the category name, then it's not working. The category and all the boards within it still show in the chatroom. If I select the category and also all of the boards it works okay, but not by selecting the category name only.
I have noticed that if I do just select a category name and then go back to Admin Center, all the boards in that category are selected as they should, but from the first save it doesn't seem to take effect.

Carsten wrote on Sep 30th, 2009 at 5:07pm:
Fixed bug when excluding a board with the same id as a category.

I'm not too sure what your fix was but, if I select a category name only, and there is a board in that category with the same id, then that category and all the boards within it appear in the chatroom, apart from the board with the same id.

Also, I don't know if this is the way you mean it to work but, when I do select whole categories to not show in the chatroom, the category names are still visible. Should they be? See attached image:

I hope that makes sense. Smiley
« Last Edit: Oct 3rd, 2009 at 2:03am by Derek Barnstorm »  

ChatCats.png ( 19 KB | Downloads )
ChatCats.png
Back to top
 
IP Logged
 
Carsten
God Member
*****
Offline


...to much YaMS

Posts: 3281
Location: Langå
Joined: Aug 2nd, 2002
Gender: Male
Re: Chat CE 4 YaBB 2.4 beta 0.7.2
Reply #26 - Oct 3rd, 2009 at 5:23pm
Print Post  
OMG! Attached wrong .mod file to the beta 0.8 package - sorry.  Changes are in Settings_Main.pl

Fixed the option group labels for empty categories in the selector. Changes are in ChatCE.pl

New beta 0.8.1 package attached to first post.
  

If you knock your head against a brick wall and hear a hollow sound, it's not necessarily coming from the wall.
Back to top
 
IP Logged
 
Derek Barnstorm
God Member
*****
Offline



Posts: 1146
Location: Warwickshire
Joined: Mar 23rd, 2008
Gender: Male
Re: Chat CE 4 YaBB 2.4 beta 0.8.1
Reply #27 - Oct 3rd, 2009 at 7:09pm
Print Post  
Thanks Carsten!

All is good now!

If I could make one final suggestion. When selecting a new room from the select drop down, maybe it would be a good idea for the url in the browser address bar to reflect the board/room you are in. The reason being, if I enter the chatroom and then select a different room, if I then view a members profile or go anywhere else, when I hit the browser back button, I'll always end up in the general chatroom rather than the room that I chose to be in.

So rather than the url always being:

Code
Select All
http://mysite.com/yabb2/YaBB.pl?action=chat 


After selecting a room it would be:

Code
Select All
http://mysite.com/yabb2/YaBB.pl?action=chat;room=myroom 


It's not at all important, I just thought it might make it that little bit more user friendly. I don't know what your thoughts are on that?
  
Back to top
 
IP Logged
 
Carsten
God Member
*****
Offline


...to much YaMS

Posts: 3281
Location: Langå
Joined: Aug 2nd, 2002
Gender: Male
Re: [Done] Chat CE 4 YaBB 2.4 ver. 1.0
Reply #28 - Oct 4th, 2009 at 10:52am
Print Post  
This mod is now to be considered final release ver. 1.0  Smiley

All changes since beta 0.8.1 are in ChatCE.pl

New package attached to first post.


@Derek - i get your point, but imho it's not a good idea and almost a 'no can do' because that would mean a total reload of YaBB instead of just reloading the contents of the chat iframe.
  

If you knock your head against a brick wall and hear a hollow sound, it's not necessarily coming from the wall.
Back to top
 
IP Logged
 
Derek Barnstorm
God Member
*****
Offline



Posts: 1146
Location: Warwickshire
Joined: Mar 23rd, 2008
Gender: Male
Re: [Done] Chat CE 4 YaBB 2.4 ver. 1.0
Reply #29 - Oct 4th, 2009 at 3:35pm
Print Post  
Okay, no worries. It's fine as it is anyway.

Everything's great!

Thanks!

Smiley
  
Back to top
 
IP Logged
 
Page Index Toggle Pages: 1 [2] 3 4 5
Send TopicPrint