Page Index Toggle Pages: 1 Send TopicPrint
Hot Topic (More than 10 Replies) [DONE] Hide User Info for Guests V1.0 (Read 6833 times)
Spikecity
God Member
*****
Offline


Beer anyone ?

Posts: 2630
Location: New York
Joined: Apr 16th, 2002
Gender: Male
[DONE] Hide User Info for Guests V1.0
Jul 13th, 2002 at 2:45pm
Print Post  
By Request Wink

Hide Member Profile and Info

Version 1.0

Version History

1.0
Initial Release

What it does ?
This mod will hide stuff like  YIM, MSN, AIM and
email address and website (unless the user allows it to be visible) for Guests.
I actually found that not selecting hide your email address is linked with your websites visibility too ??
It also prevents Guests from viewing a user profile from the thread links.

How to install ?
As usual with boardmod 2.5 or equal.
Upload the modified files.
Which are:
Sources/Profile.pl
Sources/Display.pl

Ron, Spikecity

http://www.spikecity.net
  

Nothing to add here Smiley
Back to top
 
IP Logged
 
BHRA Webmaster
God Member
*****
Offline


Mod Author of the Year
2002

Posts: 5238
Location: BHRA Headquarters
Joined: Jan 18th, 2002
Gender: Male
Re: [DONE] Hide User Info for Guests V1.0
Reply #1 - Jul 13th, 2002 at 2:53pm
Print Post  
Has this mod been tested and varified by at least one other person as "bug free"?

(If it hasn't then it isn't [DONE] is it!)
  


World Domination, one smiley at a time!
Back to top
 
IP Logged
 
Spikecity
God Member
*****
Offline


Beer anyone ?

Posts: 2630
Location: New York
Joined: Apr 16th, 2002
Gender: Male
Re: [DONE] Hide User Info for Guests V1.0
Reply #2 - Jul 13th, 2002 at 3:10pm
Print Post  
Quote:
Has this mod been tested and varified by at least one other person as "bug free"?

(If it hasn't then it isn't [DONE] is it!)

I always test my mods on three boards.
One clean board on my dev PC, one heavily modded board also on my dev pc and last but not least live on www.spikecity.net.
Ok, I agree that this testing is done by one person, but on three different setups of boards, so if they fail....
If it installs and works on all three it's done for me Wink
I have some faith in what I'm doing here, and the trackrecord for the majority of my own mods is far from being bad Wink
  

Nothing to add here Smiley
Back to top
 
IP Logged
 
BHRA Webmaster
God Member
*****
Offline


Mod Author of the Year
2002

Posts: 5238
Location: BHRA Headquarters
Joined: Jan 18th, 2002
Gender: Male
Re: [DONE] Hide User Info for Guests V1.0
Reply #3 - Jul 13th, 2002 at 3:17pm
Print Post  
Sorry, just having a quick whinge.

Quote:
I have some faith in what I'm doing here, and the trackrecord for the majority of my own mods is far from being bad.

It's great you feel that way, but I always seem to miss something....

  


World Domination, one smiley at a time!
Back to top
 
IP Logged
 
Spikecity
God Member
*****
Offline


Beer anyone ?

Posts: 2630
Location: New York
Joined: Apr 16th, 2002
Gender: Male
Re: [DONE] Hide User Info for Guests V1.0
Reply #4 - Jul 13th, 2002 at 3:33pm
Print Post  
Quote:
Sorry, just having a quick whinge.

It's great you feel that way, but I always seem to miss something....



Grin.... if you don't believe in yourself, who to believe in then  8)
The only part where I sometimes screw up is making a mod out of the changed code.
Be sure that the code IS working on three boards, but I made it a "bad" habit to make the mods in notepad and there.... I sometimes, but very rarely forget one line of changed code.
Out of a total of 40+ mods I did (of which about 10 of my own) and the rest translated and adapted to SP1.1 it happened to me only once (better knock on wood Grin )
If you're wondering why they are not all upped here ??
Time.... or better lack of time Wink
Dave has the majority in his inbox, the latest 5 or 6 are here in the threads for him to pick off the board.
  

Nothing to add here Smiley
Back to top
 
IP Logged
 
BHRA Webmaster
God Member
*****
Offline


Mod Author of the Year
2002

Posts: 5238
Location: BHRA Headquarters
Joined: Jan 18th, 2002
Gender: Male
Re: [DONE] Hide User Info for Guests V1.0
Reply #5 - Jul 13th, 2002 at 3:46pm
Print Post  
Well, to get this thread back on topic, I've been testing you mod.

I have one question - are guests supposed to see the email addresses of other guests? I am of course referring to this:

Code
Select All
      if($musername ne "Guest") {
            $yymain .= qq~
            $star<BR><BR>
            $userprofile[13]$userprofile[12]
~;
      }
      if($username ne "Guest") {
            $yymain .= qq~
            <BR>$userprofile[8] $icqad &nbsp; $userprofile[10] $yimon &nbsp; $userprofile[9]<BR>
~;
      }
      if($musername eq "Guest" && $username ne "Guest" ) {
            $yymain .= qq~
            <BR><a href="mailto:$memail">$img{'email_sm'}</a><BR><BR>
~;
      }
      elsif ($userprofile[19] ne "checked" || $settings[7] eq "Administrator" || $allow_hide_email ne 1) {
            $yymain .= qq~
            $profbutton$userprofile[4] <a href="mailto:$memail">$img{'email_sm'}</a>$sendm<BR><BR>
~;
      } elsif($username ne "Guest") {
            $yymain .= qq~
    $profbutton$userprofile[4]$sendm<BR><BR>
~;
      }

 



This mod adds the $username ne "Guest" condition to the if statement to stop guests from viewing the email addresses of other guests, but because this is followed by an elsif statement, the guest email addresses are still visible (the "if" statement is false so it executes the "elsif" code instead)


I think what it should be is this:

Code
Select All
      if($musername ne "Guest") {
            $yymain .= qq~
            $star<BR><BR>
            $userprofile[13]$userprofile[12]~;
            if($username ne "Guest") {
                  $yymain .= qq~
            <BR>$userprofile[8]      $icqad &nbsp; $userprofile[10] $yimon &nbsp; $userprofile[9]<BR>
~;
            }
      }
if($username ne "Guest") {
      if($musername eq "Guest") {
            $yymain .= qq~
            <BR><a href="mailto:$memail">$img{'email_sm'}</a><BR><BR>
~;
      }
      elsif ($userprofile[19] ne "checked" || $settings[7] eq "Administrator" || $allow_hide_email ne 1) {
            $yymain .= qq~
            $profbutton$userprofile[4] <a href="mailto:$memail">$img{'email_sm'}</a>$sendm<BR><BR>
~;
      } else {
            $yymain .= qq~
    $profbutton$userprofile[4]$sendm<BR><BR>
~;
      }
}
      $yymain .= qq~

 


(With this version, Administrators see all emails, members see the emails of guest and members that allow it, guests see none!)
« Last Edit: Jul 13th, 2002 at 6:12pm by BHRA Webmaster »  


World Domination, one smiley at a time!
Back to top
 
IP Logged
 
Teme
Senior Member
****
Offline


Cogito, ergo sum!

Posts: 432
Joined: Dec 31st, 2001
Gender: Male
Re: [DONE] Hide User Info for Guests V1.0
Reply #6 - Jul 13th, 2002 at 7:21pm
Print Post  
I think guests should see the mails of other guests (it's their problem if they're not members). It should be just members' benefit to hide that info.
  

My great wish list:
Quote inside Quote! (and I'll be satisfied)
Back to top
WWWICQ  
IP Logged
 
Spikecity
God Member
*****
Offline


Beer anyone ?

Posts: 2630
Location: New York
Joined: Apr 16th, 2002
Gender: Male
Re: [DONE] Hide User Info for Guests V1.0
Reply #7 - Jul 13th, 2002 at 10:14pm
Print Post  
Quote:
Well, to get this thread back on topic, I've been testing you mod.

So you're the one other person to get a mod DONE Grin
Quote:
I have one question - are guests supposed to see the email addresses of other guests? I am of course referring to this:

The only reference to a Guest is his email address and hiding stuff is a priviledge for members only I think.
A guest isn't supposed to have any hiding priviledges on a board.

So yes, Guest email adresses are always visible for everyone and members email/website only if a members unsets his hide email in his/her profile.
Quote:
(With this version, Administrators see all emails, members see the emails of guest and members that allow it, guests see none!)


You're analysis is absolutely correct "Holmes" Grin

I had this code (like you suggested) first but it still showed the website from members for guests and the request I read from the Mod ideas and feedback board was to hide everything including the site.
Either option is fine by me, I only made what was requested.

  

Nothing to add here Smiley
Back to top
 
IP Logged
 
BHRA Webmaster
God Member
*****
Offline


Mod Author of the Year
2002

Posts: 5238
Location: BHRA Headquarters
Joined: Jan 18th, 2002
Gender: Male
Re: [DONE] Hide User Info for Guests V1.0
Reply #8 - Jul 13th, 2002 at 11:11pm
Print Post  
I've installed your original version on my test bench, and when a guest views a thread, they can see the email addresses of other guests, and the profile, email and website icons of members who have the "hide email" checkbox unchecked. I think the original request from Schoolmarm, was to hide everything.

Schoolmarm wrote on Jul 13th, 2002 at 9:08am:
... Is it possible to hide  members profiles from guests? Most importantly, to hide their emails and YIM or AIM info.

Also, this member profile info needs to be hidden to guests on member's individual posts made in the "guest board".

See, since guests are not allowed to access the Member's list which displays this info. I don't think it is appropriate for them to access personal contact information which members don't mind other members knowing -- but not just anyone.


Maybe Schoolmarm can clarify her request.
  


World Domination, one smiley at a time!
Back to top
 
IP Logged
 
Schoolmarm
New Member
*
Offline


I love YaBB 1G - SP1!

Posts: 43
Joined: Feb 18th, 2002
Re: [DONE] Hide User Info for Guests V1.0
Reply #9 - Jul 14th, 2002 at 2:57am
Print Post  
Hi,
Wow, didn't expect such a fast answer to my mod request! Thanks so much - Spikecity (you are awesome!) Smiley

I just got in here today, so I haven't had a chance to download the mod and try it out. But, to clarify:

Quote:
(With this version, Administrators see all emails, members see the emails of guest and members that allow it, guests see none!)


The quote above reflects exactly what I had wanted concerning emails -- and would be the model for the other personal info of members.

And, I agree with Teme that:
Quote:
I think guests should see the mails of other guests (it's their problem if they're not members). It should be just members' benefit to hide that info.


But, if its easier to code by hiding all including guests' emails to guests -- that is fine too. I just want to protect my members from any passerby that might be intent on mischief by gathering their personal info.

Does that help clarify? I am also running a SP1 version (so sorry I forgot to mention that important fact). However, its heavily modified and should be able to handle Sp1.1 mods.

Off to go test ....
  
Back to top
 
IP Logged
 
Schoolmarm
New Member
*
Offline


I love YaBB 1G - SP1!

Posts: 43
Joined: Feb 18th, 2002
Re: [DONE] Hide User Info for Guests V1.0
Reply #10 - Jul 14th, 2002 at 7:01am
Print Post  
Okay, Now that I have had a visual basis -- I understand the conversation better here. I tested. The mod installed easily. I found that this mod does hide the member profile from the guests. But, allows Guests to view the icons for the YIM, AIM, ICQ, Email, & Website of members. I double checked with a Clean Display.Pl with the same result.

I really did want to hide all personal (member profile type) info from Guests. So, BHRA was correct with his understanding of my request... I did take his code for Step 3 and apply it to display.pl achieving the exact results I was looking for Smiley

Now, BHRA's modification also prevents Guests from seeing other Guests Emails. Thats okay. I didn't expressly want that -- But, hey... Now, that I think about it.. it just might be a good thing. So, guests will feel comfortable about leaving their real emails instead of bogus ones to protect their privacy. I am very happy!

Ron and BHRA through both of your efforts, I now have the PERFECT Yabb board. Whoo Hoo! [At least until another mod catches my eye]  Wink Thanks so Much - both deserve a big hug for helping out this lady!

I have included BHRA's modifications to Ron's initial release of the Mod -- incase anyone else wants it -- It is attached as Version 2. I tested it through BoardMod 2.5 and on my testboard. To make sure there weren't any errors and it worked for me. I also made sure both authors were credited. Is that okay for me to do that? -- If not, please remove my attachment.
  
Back to top
 
IP Logged
 
BHRA Webmaster
God Member
*****
Offline


Mod Author of the Year
2002

Posts: 5238
Location: BHRA Headquarters
Joined: Jan 18th, 2002
Gender: Male
Re: [DONE] Hide User Info for Guests V1.0
Reply #11 - Jul 14th, 2002 at 9:32am
Print Post  
Fine by me, after all that's what beta testing for!!!
  


World Domination, one smiley at a time!
Back to top
 
IP Logged
 
Spikecity
God Member
*****
Offline


Beer anyone ?

Posts: 2630
Location: New York
Joined: Apr 16th, 2002
Gender: Male
Re: [DONE] Hide User Info for Guests V1.0
Reply #12 - Jul 15th, 2002 at 9:39am
Print Post  
Quote:
Fine by me, after all that's what beta testing for!!!

Ok by me too, if you are happy I'm too.
I'll just add the modified mod into the zip and make a note in the readme which version does what.
As I still think hiding of guest emails is an option I would not like, as I would like to encourage guests to become members and have these fine priviledges.

Glad that this joint effort made you happy Grin

  

Nothing to add here Smiley
Back to top
 
IP Logged
 
DanX vs SoNiC
God Member
*****
Offline


TOTTENHAM HOTSPURS FOREVER!!!

Posts: 1675
Location: Scarborough
Joined: Sep 4th, 2001
Gender: Male
Re: [DONE] Hide User Info for Guests V1.0
Reply #13 - Jul 15th, 2002 at 5:16pm
Print Post  
Good idea. Should stop guest spamming users now!! 8)
  

Email "The User Formally Known As Sonic : mail@danscotson.co.uk
Back to top
 
IP Logged
 
Spikecity
God Member
*****
Offline


Beer anyone ?

Posts: 2630
Location: New York
Joined: Apr 16th, 2002
Gender: Male
Re: [DONE] Hide User Info for Guests V1.0
Reply #14 - Jul 18th, 2002 at 8:18pm
Print Post  
Quote:
Good idea. Should stop guest spamming users now!! 8)

So we have two happy users for this mod now Wink
It's getting populair Grin
  

Nothing to add here Smiley
Back to top
 
IP Logged
 
Page Index Toggle Pages: 1
Send TopicPrint